Senku
Senku
> I have left some reviews. You can resolve the addressed ones to avoid cluttering. I will go over the correctness of the code once you add more tests. Feel...
> I have left some reviews. You can resolve the addressed ones to avoid cluttering. I will go over the correctness of the code once you add more tests. Feel...
> > sir i have added the class in test_args.py > > I don't see an `assert` statement in the attached image. You need not shy from making a commit....
> > sir i have added the class in test_args.py > > I don't see an `assert` statement in the attached image. You need not shy from making a commit....
@faze-geek hello sir i have added basic tests please guide me how do i improve them edit: sir also can you please guide me why is the doctests getting failed??...
i am using series and parallel class like this - `P = TransferFunction(KP, 1, s), I = TransferFunction(KI, s, s), D = TransferFunction(KD * s, 1, s) pid_controller = Parallel(P,...
> This is trending towards the right direction. To avoid cluttering please resolve the conversations which you are done with. okay sir !
> Hi, can you fix all failing checks including `test / authors` before I review it. Feel free to mark it ready for review then. sir i don't know why...
@faze-geek sir @abhiphile wants to work on this issue so should i close this PR?
> > @faze-geek sir @abhiphile wants to work on this issue so should i close this PR? > > Anyone is free to work on any issue in SymPy. My...