moh-eulith
moh-eulith
> `summarized-benchmarks.json` artifact from the `c_ext_benchmarks job` from your PR and from the base branch Thanks for the pointer. This PR as originally written (no 200 heuristic) vs. develop: ###...
> We should actually be getting method_gas for more projects. I double checked and it's `null` in the json for develop branch. Do you know which ones? I managed to...
The build is green (I tried to fix the spurious failures). Still todo: test cases using the new test framework (no rush, just keeping track of what's left). anything else?
I added a semantic test for masks. Most masks are generated by the compiler internally, so it made sense to me to test those. (of the categories under `/test` semantic...
> A semantic test is nice, but it would be good to also have some unit tests for the optimization step itself - since there's no particular rush, it's probably...
@ekpyron I noticed there is an unused (?) test framework for the constant optimizer via `solfuzzer`. I added a human readable input option (`--hex`) and tested various masks and constants....
I reorganized the commits. The first commit adds tests with no code changes using @cameel 's new testing framework. (I like the flexibility that allows better coverage for different optimization...
Could I please get a review in the next few days? I have an upcoming trip and may not be able to give this the attention it may require. Thanks.
Thanks @yash-atreya . If I'm not mistaken, that's not documented, so maybe we can change this issue to a doc issue.
Thank you for taking a look. PR submitted with the feedback. #15935