Sergiu Moga
Sergiu Moga
Sorry for the push, thought I'd also clarify in the comment where that EBDA pointer is from.
> @mogasergiu , this needs rebasing. Done @razvand.
Hi @GrubFe :smile:! Only a small comment regarding the commit. We usually try to follow a convention of `'[Selector]/[Component]: [Short message]'` for the summary of the commit. You can do...
> @mogasergiu The commit sounds reasonable, I assume the original `mov` instruction was a mistake? Well, the type of `r_sz` is definetely bigger than 1 byte (the field in the...
The assertion should not be removed IMO, it is specified by the ACPI standard that the BSP must always come first. If we are dealing with uncompliant firmware, which is...
Apologies, I pushed again with the whole rebae :man_facepalming:. Here is the actual diff ```diff diff --git a/lib/syscall_shim/include/uk/syscall.h b/lib/syscall_shim/include/uk/syscall.h index b7d96d7d..77f2de99 100644 --- a/lib/syscall_shim/include/uk/syscall.h +++ b/lib/syscall_shim/include/uk/syscall.h @@ -514,7 +514,7 @@...
> branch from [11cde88 ](https://github.com/unikraft/unikraft/commit/11cde888ef36e1d1cec8ea96bec684f38bde72e5)to [ebf0f40 ](https://github.com/unikraft/unikraft/commit/ebf0f40ce312850594f4b2ca95abc87766a293b7) [now](https://github.com/unikraft/unikraft/pull/1346#event-12905455701) This push is a simple rebase. I will now soon push with comment feedback.
Is there a specific use-case for this addition as of now? I understand this is part of more work to come, but I would like to wait and see how...
Ah I see. Yep, I would rather we reviewed that first to see how this is actually used before merging something unused.
I think this is a good change for consistency :+1:. However, now you will have to add this dependency to libcontext, i.e. you will have to add `select LIBISRLIB` to...