Sergio Sánchez Ramírez

Results 117 comments of Sergio Sánchez Ramírez

Did you find a bug?

Super! Thank you so much @giordano I'm putting the PR as "Ready to review" so in case all test succeed, then merge.

mmm actually the library requires C++11. Do we have to support `cxx03`?

> https://docs.binarybuilder.org/stable/building/#Expanding-C-string-ABIs-or-libgfortran-versions > > > This ABI does not have to do with the C++ standard used by the source code, in fact you can build a C++03 library with...

@jofrevalles The code is basically finished and the tests have been refactored. I need to add some more tests, but the current tests are failing on comparing 2 `Tensor`s with...

@jofrevalles Seems like the problem is (again) related to the way indices are replaced when doing `merge!`. I thought it was a good idea, but we might want to rethink...

> If we want to have "nice symbols" when doing plots, we can do some conversion or something before plotting in order to fix the labels. I wouldn't change the...

mmm yes, we can close. I didn't close it before because I wanted to readd the PEPS (maybe the Dense) types but we can add them later.

> It's a bit strange to me to not immediately use the `AbstractBackend` in TensorOperations, and instead defining your own, which then wraps objects of the exact same name, but...

> Finch also supports a macro `@einsum.` Do you have any kernels in mind? In our case, einsum expressions are chosen dynamically on run-time and can be big (like involving...