Sergio Sánchez Ramírez

Results 31 comments of Sergio Sánchez Ramírez

Just backported https://github.com/llvm/llvm-project/commit/5c3beb7b1e26d38b0933a28432dfbce4e00cf329, tested in local and it works! All tests pass! ``` Executing tests that run on node 1 only: ccall (1) | started at 2024-03-04T17:44:02.738 ccall (1) |...

Now everything builds! Only thing remaining is the failing ASAN job @gbaraldi @giordano Btw, about Tier 3 platforms: - `x86_64-linux-musl` builds successfully but crashes into a OOM error when generating...

I can also replicate this with `TensorOperations`. Both of this "einsum" packages should be calling BLAS for these simple examples. ```julia using Enzyme using TensorOperations function f(ssa1::Array{Float64, 2}, ssa2::Array{Float64, 2},...

> hey @mofeing this generates a ton of code and is going to be rather hard to debug as is. Can you reproduce this in a more minimal example? The...

mmm I managed to skip one layer of OMEinsum and simplify this case to the following: ```julia using Enzyme using OMEinsum rule = OMEinsum.SimpleBinaryRule{('j',), ('j',), ()}() function h(ssa1, ssa2, ssa3)...

Ah, no. This is the only simplification I could do. It's all or nothing 🥲. Also, I don't call `fill(0.0)` inside `h`... I did a small modification (now it's doing...

Yes, in this last example is returning an array, and in the previous example a scalar. But in both cases I get `Enzyme Mutability Error: Cannot add one in place...

Ah okay, I just found the limitation in [autodiff(::Reverse)](https://enzymead.github.io/Enzyme.jl/stable/api/#EnzymeCore.autodiff-Union{Tuple{Nargs},%20Tuple{Holomorphic},%20Tuple{RABI},%20Tuple{ReturnPrimal},%20Tuple{A},%20Tuple{FA},%20Tuple{ReverseMode{ReturnPrimal,%20RABI,%20Holomorphic},%20FA,%20Type{A},%20Vararg{Annotation,%20Nargs}}}%20where%20{FA%3C:Annotation,%20A%3C:Annotation,%20ReturnPrimal,%20RABI%3C:EnzymeCore.ABI,%20Holomorphic,%20Nargs}) If I add a `only` to `h`, ```julia function h(ssa1, ssa2, ssa3) OMEinsum.binary_einsum!(rule, ssa1, ssa2, ssa3, true, false) return only(ssa3) end...

So I guess the problem is in between `einsum!` and `binary_einsum!`, which is the code in... https://github.com/under-Peter/OMEinsum.jl/blob/327cf355c746e9f646c5beee74dcd2c11aa90240/src/einsum.jl#L99-L117

nothing seems to have changed 🥲 but I think I might me on the way of having a MWE (this issue might not be the only source of error). I...