qksms icon indicating copy to clipboard operation
qksms copied to clipboard

Copy partial text

Open moezbhatti opened this issue 6 years ago • 10 comments

Instead of needing to copy an entire message, you should be able to just copy the part that you want

moezbhatti avatar Apr 30 '18 18:04 moezbhatti

android:textIsSelectable attribute to message body view should do the trick but those text view seems to forward their touch event to the root layout they are in

GeoZac avatar Mar 01 '20 05:03 GeoZac

Unfortunately it's not quite so simple, because long-pressing the message is currently how you access multi-select. So all of that will need to be reworked

moezbhatti avatar Mar 03 '20 04:03 moezbhatti

Since the root view already has the OnLongClickListener , with forwardTouches(view) disabled, the multiselect works when touch is anywhere outside the message body( with the root view), which is an appreciable area.

P.S.:I had been playing around with these changes for last few days, and no regressions were observed

GeoZac avatar Mar 03 '20 04:03 GeoZac

Hmm interesting, I hadn't thought about leaving the hold-for-multiselect. Although I think it might be a bit confusing if you have to hold outside of the message in order to select it

I was thinking of implementing #1277 at the same time as this, as a solution to that problem

moezbhatti avatar Mar 03 '20 04:03 moezbhatti

Finally working on this! Tracking progress in https://github.com/moezbhatti/qksms/tree/partial-copy

moezbhatti avatar May 12 '20 03:05 moezbhatti

Hats off the the amazing work. Really like the new implementation, but I cam across an issue where a third tab in the meaasge body ( first one opens the options, second dismissses it) doesn't show the options, but I can select the text, is this intentional ?

GeoZac avatar May 13 '20 15:05 GeoZac

That's on my to-do list, this is still a WIP!

moezbhatti avatar May 13 '20 16:05 moezbhatti

I'll let you know when it's closer to being ready - probably later this week

moezbhatti avatar May 13 '20 16:05 moezbhatti

It's been a year, is there any plan to implement this?

Elkasitu avatar Sep 23 '21 11:09 Elkasitu

Hi, for me, this is the biggest harm of this app. I love to use it, but when copy (f.e. an address) is needed this means "troublesomeness". As in the meantime more than two years have passed - will this freature be release in near future?

hugofant avatar Aug 27 '22 16:08 hugofant