thor icon indicating copy to clipboard operation
thor copied to clipboard

Add a .dockerignore

Open kinow opened this issue 3 years ago • 1 comments

Hi!

Congrats for thor! Learned about it from HackerNews, and was surprised by the quality of the code! :clap:

I think a .dockerignore file could be helpful, to avoid including unnecessary files in the build context.

Refs:

  • https://codefresh.io/blog/not-ignore-dockerignore-2/
  • https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#build-an-image-using-a-dockerfile-from-stdin-without-sending-build-context

I tried to quickly run thor using the Docker image, but stopped it when the last layer started downloading 1.3 GB :sweat_smile: Will leave it for when I'm connected to $work's network to save my bandwidth.

Cheers Bruno

kinow avatar Jun 06 '22 04:06 kinow

Hi @kinow -- just to quickly let you know we've seen the PR (and thanks for sending it in!). @moeyensj has been on a (well deserved!) vacation for the last week, and he'll check it out & merge as soon as he's back.

mjuric avatar Jun 10 '22 17:06 mjuric