center-randomize icon indicating copy to clipboard operation
center-randomize copied to clipboard

Download Results as pdf feature was added to the streamlit webapp

Open ShudarsanRegmi opened this issue 9 months ago • 12 comments

User can now download the generated results as pdf. image image image

ShudarsanRegmi avatar Apr 26 '24 09:04 ShudarsanRegmi

For downloading feature I don't think columns like longitude and latitude are needed👍🏻

Also add note specifying what is scode and cscode at the bottom in pdf

LuluW8071 avatar Apr 26 '24 10:04 LuluW8071

For downloading feature I don't think columns like longitude and latitude are needed👍🏻

Also add note specifying what is scode and cscode at the bottom in pdf

Need recommendations on this. Shall I make changes as mentioned above?

ShudarsanRegmi avatar Apr 26 '24 12:04 ShudarsanRegmi

Hey @ShudarsanRegmi, I have a few suggestions:

  1. Allow the user to view the downloaded directly from the UI itself. A simple toast with file URL should do the trick. I'm not sure though.
  2. Store the downloaded file in a folder named something like exports or genearated-pdfs
  3. Reduce the margins in the header to be bare minimum. Currently, there's too much gap between the elements in the heading section.
  4. Only display required columns in PDF as suggested by @LuluW8071
  5. Consider the linting of the code in order to make the code more standard.

dhirajraut1 avatar Apr 26 '24 12:04 dhirajraut1

@dhirajraut1 image Is it okay now? Do you recommend any further changes? Shall I try moving the logo to the left or it is fine?

ShudarsanRegmi avatar Apr 26 '24 13:04 ShudarsanRegmi

Looks good to me. I have made some changes that allows the user to download the files. I'd be more than happy to collaborate. image

dhirajraut1 avatar Apr 26 '24 14:04 dhirajraut1

  • Allow the user to view the downloaded directly from the UI itself. A simple toast with file URL should do the trick. I'm not sure though.

By this do you mean viewing the contents of pdf from streamlit?

LuluW8071 avatar Apr 26 '24 14:04 LuluW8071

By this do you mean viewing the contents of pdf from streamlit?

@LuluW8071 I meant the user to be able to download the file to their desired file location. Non-technical user don't have to see the file in the source directory. They can simply download the file directly. I have created something similar. See the screenshot below. image

dhirajraut1 avatar Apr 26 '24 14:04 dhirajraut1

@dhirajraut1 Is this project even for distribution for general users? This is meant to be run by the exam conducting comittee, isn't it? Why to worry too much about the download path ?

ShudarsanRegmi avatar Apr 26 '24 15:04 ShudarsanRegmi

User can now View the downloaded file directly in the browser. The rendered pdf can again be downloaded to any desired location. Further. Irrelevant columns from both the pdfs were removed and the generated files are stored in generated-pdfs folder. Margin issue on header section was also fixed. image image image

ShudarsanRegmi avatar Apr 26 '24 17:04 ShudarsanRegmi

Thank you for your effort but I see few fundamental issues with this feature -

  • There is a manual verification step which cannot be eliminated at this point. Therefore the generated by this app is at best intermediate, does not make sense to have that in print friendly format like pdf
  • See center allocation notice published by NEB it contains centers from all districts and crucially it contains registration number distributions for schools. Script must be able to distribute registration numbers before generated PDF would be useful.

Also note this is owned by NEB and not by MoEST directly, therefore MoEST logos would be inappropriate

sapradhan avatar Apr 27 '24 01:04 sapradhan

@sapradhan It may not be ready for final

  • There is a manual verification step which cannot be eliminated at this point. Therefore the generated by this app is at best intermediate, does not make sense to have that in print friendly format like pdf

The script is supposed to run again and again until all the students of all schools have not been assigned a center and if the distribution of centers is uneven. If the script gives tne best of its output then It will have to be reviewed by many other members and there will be manual allocations further. For this purpose alone it may be useful, isn't it ? Instead of sharing files like csv or tsv, better pdf can be distributed among the reviewing members.

ShudarsanRegmi avatar Apr 27 '24 01:04 ShudarsanRegmi

Instead of sharing files like csv or tsv, better pdf can be distributed among the reviewing members.

CSV and TSV are more suitable for review, edits as they can be easily dealt with spreadsheet applications. This is also for only one district, merging with other districts will also be necessary

sapradhan avatar May 04 '24 07:05 sapradhan