modxcms
Follow up to 16322: Fix non-existent snippet tags being broken up by an @ tag
What does it do?
Identifies and fixes a problem present in the getPropertySet method where the Element name is re-set, but without the necessary colon between the actual Element name and the rest of its tag.
Why It's Needed / How to Test
See PR #16322
Note
This is by and large the result of @Mark-H's work -- although it did take the better part of a night to track down the issue he was asking for help on ;-)
Thanks for taking over the PR and working on it some more. It is indeed something that takes a while to figure out - it took me like 3 days of work to get to that PR which fixed some issues, but left the one I couldn't sort out.
I've added a note to my to do list to review and dig back into this to give it a proper review. It may take me a few weeks but is on the list.
It may take me a few weeks but is on the list.
Hey @Mark-H any chance you might be able to take another peek at this one, since you were the OP? :)
@Mark-H - It's been a few few weeks (just giving you a hard time). It'd be great to get all that work that mainly you did implemented ;-) ... can you carve out some time to check this soon?
@Mark-H - Hey, I see you've been a little more active lately, so giving another bump on this one ;-)