revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Do not dynamically assign modProcessorResponse to modConnectorResponse

Open opengeek opened this issue 1 year ago • 0 comments

What does it do?

Assign the processor result to a local variable rather than dynamically creating a "response" property on the modConnectorResponse class.

Why is it needed?

In PHP 8.2, dynamically assigning a property to a class is deprecated. When calling runProcessor, the result is only used within the outputContent() method, so there is no need to assign the result from runProcessor to a property of modConnectorResponse dynamically or add a property to modConnectorResponse to hold the result.

How to test

Confirm no deprecated warnings are logged when running a processor in a connector.

Related issue(s)/PR(s)

Alternative solution to #16562

opengeek avatar Apr 23 '24 18:04 opengeek