revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Log an error when resources can't be loaded in context cache generation

Open Mark-H opened this issue 2 years ago • 1 comments

What does it do?

Checks for errors loading resources in the generation of the context cache.

Why is it needed?

This is used in the aliasMap and resourceMap, but would fail silently if the query failed. In the specific case preceding this PR, the problem was a borked migration, but it took too much sleuthing to figure out where it was failing exactly due to this information not being available.

How to test

Make sure no message gets logged in normal use.

Related issue(s)/PR(s)

N/a

Mark-H avatar Jan 10 '24 17:01 Mark-H

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (32aba73) 17.95% compared to head (62bbe83) 21.68%. Report is 59 commits behind head on 3.x.

Files Patch % Lines
core/src/Revolution/mysql/modContext.php 80.00% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16508      +/-   ##
============================================
+ Coverage     17.95%   21.68%   +3.73%     
- Complexity    10442    10497      +55     
============================================
  Files           561      561              
  Lines         39051    31706    -7345     
============================================
- Hits           7010     6877     -133     
+ Misses        32041    24829    -7212     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 10 '24 17:01 codecov[bot]