revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Update phpThumb to v1.7.22-202312071641

Open opengeek opened this issue 2 years ago • 3 comments

What does it do?

Updates phpThumb to v1.7.22-202312071641

Why is it needed?

Fixes the issue with thumbnails not being generated when running on PHP 7.4 (or earlier).

How to test

Make sure thumbnails are being generated in the media browser when running on PHP 7.4.

Related issue(s)/PR(s)

Resolves #16468 for the 2.x branch

opengeek avatar Dec 21 '23 00:12 opengeek

running on PHP 7.4 (or earlier).

If you want to support PHP versions < PHP 7.1, then there is still a problem with the void return type.

See this forum topic: https://community.modx.com/t/phpthumb-issue-with-modx-2-8-6-and-php-5-6/7224

halftrainedharry avatar Dec 21 '23 11:12 halftrainedharry

running on PHP 7.4 (or earlier).

If you want to support PHP versions < PHP 7.1, then there is still a problem with the void return type.

See this forum topic: https://community.modx.com/t/phpthumb-issue-with-modx-2-8-6-and-php-5-6/7224

We have no intention of maintaining support for a PHP version that ended both active and security support over five years ago. And I would never expect the phpThumb project to do so, either.

opengeek avatar Dec 28 '23 14:12 opengeek

I can confirm when manually applying the changes to the files in this PR that it definitely fixes the problem of missing thumbnails.

rthrash avatar Jan 24 '24 23:01 rthrash