revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Package manager should fail gracefully if package zip is corrupted

Open muzzwood opened this issue 2 years ago • 1 comments

Bug report

Summary

If a package is not downloaded completely or has been corrupted some other way, the "saving" modal animation will stay on screen forever.

Fatal error: Uncaught ValueError: Invalid or uninitialized Zip object in /var/www/html/core/vendor/xpdo/xpdo/src/xPDO/Compression/xPDOZip.php on line 152

Step to reproduce

Try to install a corrupted package.

Observed behavior

There is no feedback to the user. It appears like it's just taking a long time.

Expected behavior

If possible, there should be an error communicated to the user.

Environment

MODX version 3.0.3

muzzwood avatar Jun 30 '23 03:06 muzzwood

I have the same error on modx 2.8.6, if i switch php version to 8.

EMDM45 avatar Mar 27 '24 06:03 EMDM45