revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Add session garbage collector check

Open Ruslan-Aleev opened this issue 2 years ago • 3 comments

What does it do?

It often happens that the modx_session table grows uncontrollably (I have seen up to 5 gigabytes), which sometimes leads to complete non-operation of both the site and the server.

I added session garbage collector check in installer.

gc_installer_warn

Why is it needed?

That there were no problems with overflow of the table modx_session.

How to test

Make the installation from scratch by changing the session.gc_probability, session.gc_divisor parameters.

Related issue(s)/PR(s)

https://github.com/modxcms/revolution/pull/16287 https://github.com/modxcms/revolution/issues/16275

Ruslan-Aleev avatar Jun 18 '23 11:06 Ruslan-Aleev

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (69a7d6d) 21.75% compared to head (b3b1df3) 21.68%. Report is 28 commits behind head on 3.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                3.x   #16448      +/-   ##
============================================
- Coverage     21.75%   21.68%   -0.07%     
- Complexity    10478    10496      +18     
============================================
  Files           561      561              
  Lines         31590    31703     +113     
============================================
+ Hits           6872     6875       +3     
- Misses        24718    24828     +110     

see 14 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 18 '23 11:06 codecov[bot]

Do the lexicons need to be in both default.inc.php and test.inc.php?

Mark-H avatar Feb 10 '24 15:02 Mark-H

@Mark-H To be honest, I don’t know, I haven’t figured it out. Other keys are present in both files.

Ruslan-Aleev avatar Feb 12 '24 09:02 Ruslan-Aleev