revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Form Customization in MODX 3: Template names don't initially appear, or are wrong

Open SnowCreative opened this issue 3 years ago • 4 comments

Bug report

Summary

Template names in the list of manager customizations is sometimes missing, or displays the wrong template names.

Step to reproduce

Go to Form Customization, then click on customization name to edit the group.

Observed behavior

The template name column is empty. Screen Shot 2022-11-16 at 4 50 12 PM

Reload the screen, and the names appear. Sometimes I have to reload twice. Screen Shot 2022-11-16 at 4 50 21 PM

This happens only the first time. If you close out of the customization group, then go back to it, the template names are still there. If, however, you clear the browser cache, then go back to the customization group, the template names are gone again. I've tried with 3 different browsers.

HOWEVER, sometimes the template names that do show up are wrong, so the same template name may appear multiple times, even though there is only one customization set for that template.

Expected behavior

Template names should appear on first viewing.

Environment

MODX 3 (all versions)

SnowCreative avatar Nov 16 '22 22:11 SnowCreative

I looked at one live site running 3.0.1 and my 3.0.2-dev local install and did not see this issue.

UPDATE: Now I'm seeing this issue in various scenarios on 3.0.3-dev—sometimes when first opening a profile, sometimes after editing and closing a profile rule. Will have to look into it.

Additionally, incorrect template names are showing up on some rules (although the saved value is correct); a similar issue can happen with the media source grid component (shown in the TV creation page), particularly when the component is paged and an option is chosen from the 2nd+ page).

smg6511 avatar Nov 16 '22 23:11 smg6511

Additionally, incorrect template names are showing up on some rules (although the saved value is correct);

I am seeing this too. It seems to be worse when there are a lot of rules. Red highlighted rules show incorrect [or missing] templates:

image

Opening each rule shows everything as it should be - but it's hard to know which rule is which.

MODX 3.0.3-pl PHP 8.2

deJaya avatar Jul 18 '23 20:07 deJaya

Can we get this on a milestone somewhere?

SnowCreative avatar Apr 10 '24 22:04 SnowCreative

I'll take a look again at this soon. I played with this at one point (when verifying the issue earlier) and found it to be particularly tricky to solve. This is an issue for any multi-page combo (having more than 10 items) used in an editor grid.

smg6511 avatar Apr 12 '24 04:04 smg6511