revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Make Region IDs in Customization Forms more understandable

Open Ruslan-Aleev opened this issue 3 years ago • 3 comments

Feature request

Summary

In the Customization Forms regions ID has incomprehensible logic, as it seems to me.

For example:

  • modx-resource-settings and modx-page-settings, why 2? In my opinion modx-resource-settings is not used at all.
  • There are seemingly clear areas - modx-resource-main-left, modx-resource-main-right; modx-page-settings-left and modx-page-settings-right. But then an incomprehensible fragmentation begins: modx-resource-main-right-top, modx-resource-main-right-middle and modx-resource-main-right-bottom, although the region on the left does not have splitting into top/middle/bottom. modx-page-settings-* has modx-page-settings-box-left and modx-page-settings-box-right - now boxes appeared.

Why is it so difficult?

Suggested solution(s)

I propose to create a fixed number of regions (2 columns by 3 rows) for "Resource", "Settings" and "TV":

modx-resource-main -- modx-resource-main-left --- modx-resource-main-left-top --- modx-resource-main-left-middle --- modx-resource-main-left-bottom -- modx-resource-main-right --- modx-resource-main-right-top --- modx-resource-main-right-middle --- modx-resource-main-right-bottom

modx-resource-settings -- modx-resource-settings-left --- modx-resource-settings-left-top --- modx-resource-settings-left-middle --- modx-resource-settings-left-bottom -- modx-resource-settings-right --- modx-resource-settings-right-top --- modx-resource-settings-right-middle --- modx-resource-settings-right-bottom

modx-resource-tv -- modx-resource-tv-left --- modx-resource-tv-left-top --- modx-resource-tv-left-middle --- modx-resource-tv-left-bottom -- modx-resource-tv-right --- modx-resource-tv-right-top --- modx-resource-tv-right-middle --- modx-resource-tv-right-bottom

Or we can make 3 columns by 3 rows (left-to-right: left, middle, right; top-down: top, middle, bottom).

Related issue(s)/PR(s)

https://github.com/modxcms/revolution/issues/13968 https://github.com/modxcms/revolution/pull/16052 https://github.com/modxcms/revolution/issues/14226

Ruslan-Aleev avatar Feb 11 '22 19:02 Ruslan-Aleev

  • modx-resource-settings is not used at all.

I use modx-resource-settings frequently to add TVs to the Document tab if I need to put them under both of the columns instead of inside one of the columns. This way, I can add full-width richtext fields there, for example. In some cases, I have resources that use a lot of custom text fields, and not the main Content field. Since there is no way to put TVs in the Content area when the content field itself is turned off, modx-resource-settings is the only way to do this.

SnowCreative avatar Feb 25 '22 16:02 SnowCreative

Yes, I was wrong, modx-resource-setting can be used. But in general, this is an issue about consistency, i.e. If there were regions with a clear name, it would be easier.

Ruslan-Aleev avatar Feb 25 '22 17:02 Ruslan-Aleev

If there were regions with a clear name, it would be easier.

Yes, agreed!

SnowCreative avatar Feb 25 '22 18:02 SnowCreative