revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Published 20 hours ago • verified publisher icon modxcms

Strange bugs in a media browser

Open Ruslan-Aleev opened this issue 4 years ago • 2 comments

Bug report

Summary

Strange bugs in a media browser that break the logic of working with files:

  1. The file class does not change to active when the context menu is displayed. When a context menu appears, it is not always clear for which particular file this menu appeared, which is not convenient. Moreover, the active class is set only by left-clicking, but, in my opinion, the active class should also be set by right-clicking.

p.s. The path also escapes characters strangely (in gif, see the Path field)

browser_1

  1. When downloading a file, for some reason it is renamed to "index". When downloading in the file tree, the file is also renamed to "index".

browser_2

  1. Renaming works strangely: the renaming window does not close, tree update does not work, the name is not updated until you open the folder with these files.

browser_3_1

But if you rename file in a folder with files, then there are no such problems.

browser_3_2

3.1) If you have a file named, for example, img_1.png, then if you add / to the name when renaming (for example, im/g_1.png), then a folder is created with the name of the part before / (im) with a file inside with the name after / (g_1.png).

3.2) In addition, the path is strangely displayed in window.

  1. The browser does not delete the file for which the context menu appears, but deletes the selected ones (which has the active class). But renaming in context menu works correctly.

browser_4

  1. If, while adding a new directory, you accidentally click outside the pop-up form and try again to add the directory, the window will break. It is not clear why the last window goes under the previous one, although it should always be on top, see the picture below.

folder_bug_2

  1. Removing multiple files does not work, although it was implemented at https://github.com/modxcms/revolution/pull/13851

Environment

MODX 3 alpha3

Ruslan-Aleev avatar Jun 24 '20 09:06 Ruslan-Aleev

Will try to fix this , already fix (locally) index.php on donwloading and refreshing after deleting \ uploading.

wax100 avatar Mar 03 '21 09:03 wax100

https://github.com/wax100/revolution/commit/01f53bb557584e6d95e0a707715ab0e2546e1da1 this fix strange path Screenshot_5

https://github.com/wax100/revolution/commit/94c01857b738135db7042760c6816a5ce902ffb7 this fix multiple upload window bug Screenshot_6

https://github.com/wax100/revolution/commit/50bcaf9ed6ac87b9f3f2550a203e1023ab52f12d this fix file name (from index) to original name without any regexp checks . current #[^\w-.]#ui is incorrect Screenshot_7

wax100 avatar Mar 05 '21 12:03 wax100