revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Revert lexicon entries in all namespaces

Open JonikUl opened this issue 6 years ago • 3 comments

Feature request

Summary

At the moment only the core lexicon entries could be reset with the button 'Revert All Core Entries' in the lexicon management. It would be nice to reset other lexicon namespaces too.

Current behaviour

  • Change a value in a lexicon not in the core namespace.
  • Use Revert All Core Entries button.
  • The same value remains.

Improved behavior

  • The button should be renamed to 'Revert the entries in the selected namespace' and the namespace should be send to https://github.com/modxcms/revolution/blob/2.x/core/model/modx/processors/workspace/lexicon/reloadfrombase.class.php#L26

Environment

MODX 2.7.1

lex

JonikUl avatar Mar 01 '19 16:03 JonikUl

The button works well for the core lexicon workspace on my local 2.7.1 installation. But not in other (selected) namespaces.

This is not a bug because of the text of the button. But the behaviour could be changed by sending the selected namespace to the processor and change the button text.

Jako avatar Mar 01 '19 20:03 Jako

I have changed the issue into a feature request. Is this ok?

Jako avatar Mar 01 '19 21:03 Jako

Very strange button :) The button work only for "core", although the first one in the list of namespaces may be not "core", but, for example, "ace". Today we noticed this bug, the problem is also in translation, for example, in Russian, there is no mention that the button only works for "core". We tested in Russian, and when we recorded gif we didn’t pay attention to the original name in English.

Ruslan-Aleev avatar Mar 01 '19 21:03 Ruslan-Aleev