revolution icon indicating copy to clipboard operation
revolution copied to clipboard

Manager menus change on upgrade

Open SnowCreative opened this issue 6 years ago • 8 comments

Summary

I know there was an issue about this a while ago, and I believe that was closed, but I've searched and can't find it. Changes to main menu items get reverted on every upgrade, making it impossible to allow clients to upgrade MODX and Extras themselves.

Step to reproduce

Make a change to any menu item, either the position in its menu, or move it to a different menu.

Observed behavior

After updating, everything goes back where it was. Same is true when updating Extras.

Expected behavior

I like to have the Extras be in alpha order under the Extras menu. Also, certain extras, like Client Config, I like to put under the Site menu instead (I rename the Content menu to Site); it's a more logical place for my clients to find that.

The issue that was closed before, that I can't find, suggested created a new custom menu to remedy the situation, but that's a poor option. Why can't the upgrade process leave the "menuindex" field in the menus table alone during upgrading? Same for the "parent" field. It seems upgrading resets the menuindex to 0 for extras. It doesn't seem like this would be a terribly difficult behavior to change.

The menu shifting is the main reason I can't hand off upgrading core software and extras to my clients, making more work for me than I want to have to deal with. I've got over 70 MODX sites that need to be kept current.

Environment

All versions of MODX.

SnowCreative avatar Aug 17 '18 15:08 SnowCreative

Was it this one https://github.com/modxcms/revolution/issues/13615 @rainbowtiger ?

jonleverrier avatar Aug 17 '18 17:08 jonleverrier

That also describes the problem, but it's not the issue entry I was referring to. There was an issue that had lots of comments, and someone suggested making custom menus.

SnowCreative avatar Aug 17 '18 17:08 SnowCreative

The problem (or maybe not, because IDK how to update items when it really needed) that in build script menu items configured with property xPDOTransport::UPDATE_OBJECT => true that means, that these items will be updated during the upgrade.

alroniks avatar Aug 17 '18 20:08 alroniks

#14394

Ibochkarev avatar Feb 18 '19 04:02 Ibochkarev

Hi friends! On freshest MODX 2.8.7 same problem, IMHO it's need to be fixed → menu item positions, manual sort order and nest structure must be preserved after MODX updated!

See the screenshot: 2024-04-11_21-03-40

dimasites avatar Apr 11 '24 19:04 dimasites

Support

ShevArtV avatar Apr 11 '24 19:04 ShevArtV

I agree with @dimasites. We need patch for this accident

biz87 avatar Apr 11 '24 19:04 biz87

denius-dev avatar Apr 11 '24 19:04 denius-dev