fred icon indicating copy to clipboard operation
fred copied to clipboard

Element settings button not working

Open davidpede opened this issue 5 years ago • 10 comments

In the frontend, clicking the settings buttons in nested elements closes the hover transition instead of opening the settings panel:

2019-06-17_10-30-51

Using Chrome & latest master branch as of today

davidpede avatar Jun 17 '19 09:06 davidpede

More strange behavior

2019-06-17_10-36-30

davidpede avatar Jun 17 '19 09:06 davidpede

This is for sure not beta2

theboxer avatar Jun 17 '19 10:06 theboxer

This is for sure not beta2

Arg sorry your right - its latest master branch as of today

davidpede avatar Jun 17 '19 10:06 davidpede

Hi David, thanks for the reports. Can you update to the latest-latest master branch (as of a few minutes ago) and force-clear your cached CSS/JS to see if these are still reproducible?

rthrash avatar Jun 19 '19 15:06 rthrash

No difference @rthrash except a slight opacity change on the buttons. Behavior above is still happening

davidpede avatar Jun 20 '19 07:06 davidpede

Hi @davidpede, having trouble reproducing this behavior. Can you supply your Dropzone and Elements templates so we can investigate further? We're considering this the last blocker to beta4 release. Appreciate your digging into this with us. :)

rthrash avatar Jun 20 '19 15:06 rthrash

Also, which browser are you using?

rthrash avatar Jun 20 '19 16:06 rthrash

Using latest Chrome. This problem feels very similar to: https://github.com/modxcms/fred/issues/160

Elements in demos above have bootstrap flex column classes applied like:

<div data-fred-block-class="col-{{ col }} mb-3" data-fred-name="text" data-fred-rte="true">
  <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras sit amet justo sit amet augue imperdiet aliquet vitae sed enim. Curabitur nec sem ex. Aenean suscipit ultrices sapien eu euismod. In sit amet massa elit.</p>
</div>

Dropzone in Tpl like:

<!-- Page content -->
<div class="page-content container-fluid">
    <div class="row">
        <!-- Main sidebar -->
        [[$sideBarLeft]]
        <!-- /main sidebar -->
        <!-- Main content -->
        <div class="col-9">
            <div class="outer-dropzone" data-fred-dropzone="content" style="min-height: 250px;">
                [[*content]]
            </div>
        </div>
    </div>
    <!-- /main content -->
</div>
<!-- /page content -->

davidpede avatar Jun 20 '19 16:06 davidpede

@rthrash found how to reproduce, its when you click on editable text. With an element like this:

<div data-fred-block-class="col-{{ col }} mb-3" data-fred-name="text" data-fred-rte="true">
  <p>Lorem ipsum dolor sit amet, consectetur adipiscing elit. Cras sit amet justo sit amet augue imperdiet aliquet vitae sed enim. Curabitur nec sem ex. Aenean suscipit ultrices sapien eu euismod. In sit amet massa elit.</p>
</div>
  1. hover over the element
  2. click its setting cog
  3. works fine

Now try:

  1. hover over the element
  2. click/select the editable text
  3. click its setting cog
  4. closes the toolbar buttons instead of opening settings

2019-06-21_10-47-06

Can you reproduce?

davidpede avatar Jun 21 '19 09:06 davidpede

Hi @davidpede we'll work on this one for a future bug release. Thanks for doing the research on repeating it.

rthrash avatar Jun 27 '19 16:06 rthrash