Tagger icon indicating copy to clipboard operation
Tagger copied to clipboard

Tag names don't work with commas

Open jmacdonald-spectacle opened this issue 4 years ago • 4 comments

If I add a tag like 'Peace, Love & Understanding,' the tag won't save with the resource.

Removing the comma will let the tag save, but if commas in tag names aren't allowed they should be restricted from being added. (or, at least, documented)

Tagger version : 1.12.0 MODX version: 2.8.1

jmacdonald-spectacle avatar Feb 25 '21 19:02 jmacdonald-spectacle

I added the tag in the Tagger Tags tab. If I try to add it in the resource, I'll get two tags.

jmacdonald-spectacle avatar Feb 25 '21 19:02 jmacdonald-spectacle

I have the same problem. Tagger 1.12.0-pl MODX 2.8.4-pl

pbowyer avatar Aug 02 '23 17:08 pbowyer

@pbowyer This has been addressed with Tag Labels

matdave avatar Aug 04 '23 19:08 matdave

@pbowyer This has been addressed with Tag Labels

Can you describe what you mean exactly by tag labels fixing the issue? I don't see how that is working.

If I have tag with a comma, like the chemical name "1,3-butadiene", I tried entering that for the label and "1,3-butadiene" for the tag. When I try to add that tag to a resource by typing in the field (start typing "1,3" and the popup then lists the tag), it gets entered in the field as "1, 1,3-butadiene,", creating two tags, one of which is just "1". If I enter "1,3-butadiene" for both the tag and label, then I can insert the tag properly, but "1,3-butadiene" shows up as the tag name in the field until I hit the 'Assign" button; then the tag goes in the list below the field with the correct formatting (showing a comma).

I could make the actual tag "1-3-butadiene", but that would look wrong to scientists using the site, even though it only appears briefly in the field before clicking Assign. And, no matter what I make the actual tag, for any group that has a large number of tags, typing needs be enabled for easy selection, and so someone will type in "1,3" (since the popup doesn't show up until at least 3 characters are entered), and when they select "1,3-butadiene" from the popup list, the field will only replace the "3" with the actual tag; the "1" will get entered as a separate tag.

Also, for any group that allows adding tags by typing them into the resource Tag field, if someone tries to add a tag that has a comma in it, that will create two tags.

SnowCreative avatar Sep 26 '23 15:09 SnowCreative