Login icon indicating copy to clipboard operation
Login copied to clipboard

ConfirmRegister controller and register processor are hard-coded to use modFileRegister

Open martinf55 opened this issue 7 years ago • 3 comments

Using registry.modFileRegister means activations fail in load balanced environments when the registration request happens on a different server to the activation request.

martinf55 avatar Oct 22 '18 11:10 martinf55

Would it i.e. help to make the properties in these lines configurable by a system setting? https://github.com/modxcms/Login/blob/master/core/components/login/controllers/web/ConfirmRegister.php#L130-L131

Sorry, but I don't have any experience in balanced environments.

Jako avatar Oct 23 '18 10:10 Jako

Yes, I've forked the project, hopefully I can put together a pull request which allows a system setting login.registry_class to override the registry.modFileRegister with registry.modDbRegister.

I've had the modDbRegister working locally, but just bumped into some kind of concurrency issue when on a load-balanced environment (possibly a lingering database lock). Once that's fixed I should have something to PR here.

martinf55 avatar Oct 23 '18 10:10 martinf55

Maybe you could ask @opengeek wether he has some tip for this.

Jako avatar Oct 23 '18 11:10 Jako