module-federation
v1.0.0: deploy examples to github pages.
@gioboa will be very useful to add extra steps to our github action to deploy examples to github pages.
This article covers it: https://javascript.plainenglish.io/deploying-a-vite-app-to-github-pages-using-github-actions-a-step-by-step-guide-ff63d93e4da2
we just need to repeat it twice. Once for host and once for remote.
I can deploy the examples on my CloudFlare account too. I'm wondering if it is better to have these examples in the main repo with all the other module-federation examples
probably best is to keep here, as thanks to you it is easier to maintain them.
If you want, we can have examples folder in main repo with symlinks to here.
On Thu, 15 Aug 2024, 13:06 Giorgio Boa, @.***> wrote:
I can deploy the examples on my CloudFlare account too. I'm wondering if it is better to have these examples in the main repo with all the other module-federation examples
— Reply to this email directly, view it on GitHub https://github.com/module-federation/vite/issues/57#issuecomment-2291150874, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAI5PLBW6AFX5Y33VCGWVIDZRSKWDAVCNFSM6AAAAABMSCLAQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOJRGE2TAOBXGQ . You are receiving this because you authored the thread.Message ID: @.***>
they are easy to deploy, and since they are static bundles, no node server is needed. the benefit is that they will help a lot to understand what this project does. Otherwise, one has to check out, install, and run locally just to try them. Examples are also playing the role of the documentation for us currently
btw, @gioboa, great article you posted on this effort, and thanks for mentioning me. Seems you did not have my name and just put username. It's Huseyn Guliyev if you want to have a full name there.
Yep, thanks 😂 I think it's time consuming to maintain all the examples with a high quality. we can grab few screenshots for all of them and deploy the most complicated and complete one. With this approach we will reduce the effort in long term.
Do you have anything deployed yet? I can't for the life of me make this work in a deployed app, it would be nice to have an app that works deployed and code for it, so we can just compare what's different.
Found an example that will actually run from the built assets folder, it's the official one as well, so my bad I didn't start with it: https://github.com/gioboa/react-microfrontend-demo?tab=readme-ov-file
@gioboa does this still need to be open. might make sense to try and clean up some of the oldest issues
Yeah, thanks for your help. May I ask you to comment stale issues (like this one) ? I will verify and close them 👍