external-remotes-plugin icon indicating copy to clipboard operation
external-remotes-plugin copied to clipboard

Deprecation notice?

Open einarq opened this issue 2 years ago • 4 comments

Should this plugin be deprecated, in favor of the "promise new Promise" approach thats recommended in the docs?

einarq avatar Jul 06 '22 09:07 einarq

@einarq Hi, does the plugin still works?

lessfish avatar Oct 12 '22 01:10 lessfish

This is a much more declarative way to customize the URL in runtime. When using "promise new Promise", I have to copy and modify code into every project which is an "ugly" solution to me.

SunHuawei avatar Jan 10 '23 09:01 SunHuawei

I agree. There probably is a good reason tho I guess. Personally I've created some utils for dealing with stuff like this, and sharing it in an npm package on our internal npm feed, so that I don't end up copy-pasting this around.

einarq avatar Jan 10 '23 09:01 einarq

@einarq, yes, that's a good solution. I just prefer not to customize it if possible, in order to reduce the effort of maintenance and to save time for the other team members to understand the solution.

SunHuawei avatar Jan 10 '23 09:01 SunHuawei