core icon indicating copy to clipboard operation
core copied to clipboard

chore(utils): add react 19 to peer dependencies

Open cheesestringer opened this issue 8 months ago • 2 comments

Description

Add react 19 to the optional peer dependencies for the utilities package and run pnpm i. Removes some warning noise when using react 19.

Related Issue

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have updated the documentation.

cheesestringer avatar Mar 25 '25 09:03 cheesestringer

⚠️ No Changeset found

Latest commit: 26bef9b40e82f8dd5b059f5244513725b0a02cff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 25 '25 09:03 changeset-bot[bot]

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit 26bef9b40e82f8dd5b059f5244513725b0a02cff
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67e64dc78d2eeb0008b027d7
Deploy Preview https://deploy-preview-3630--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 25 '25 09:03 netlify[bot]

the utilities package is dead, you should not be using it at all. You should be using module-federation/runtime

ScriptedAlchemy avatar Mar 28 '25 07:03 ScriptedAlchemy

Looks like utilities is a dependency in the node package https://github.com/module-federation/core/blob/main/packages/node/package.json#L72 which causes the warning to show up. Should I close this one and create a new PR to look at removing the dependency?

cheesestringer avatar Mar 28 '25 08:03 cheesestringer

Yes please. I don't believe anything should be using that anymore.

ScriptedAlchemy avatar Mar 28 '25 10:03 ScriptedAlchemy

Closing in favor of https://github.com/module-federation/core/pull/3646

cheesestringer avatar Mar 29 '25 07:03 cheesestringer