core icon indicating copy to clipboard operation
core copied to clipboard

fix(dts-plugin): support exposes files with multiple dots in names

Open artieeez opened this issue 1 year ago • 2 comments

Description

In /packages/dts-plugin/src/core/lib/typeScriptCompiler.ts:89, the regex already removes the .d.ts extension, so the expose path can be correctly mapped to an entry. Calling removeExt was further processing paths like foo.component to just foo, resulting in undefined being returned in getExposeKey.

I didn't check the testing checkbox because I encountered issues with some tests even before making the changes. I hope that, even if this PR doesn't meet the criteria for merging, it can at least serve as documentation for someone else to fix it.

Related Issue

https://github.com/module-federation/core/issues/2957

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have updated the documentation.

artieeez avatar Sep 17 '24 21:09 artieeez

⚠️ No Changeset found

Latest commit: f06e283fe67040cddc7626774aa352ce189c211a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 17 '24 21:09 changeset-bot[bot]

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit f06e283fe67040cddc7626774aa352ce189c211a
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66f5523646c6350008f6cbfa
Deploy Preview https://deploy-preview-2958--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 17 '24 21:09 netlify[bot]

Hi @ScriptedAlchemy,

I’ve requested your review again because I rebased the branch. Some tests that were failing in GitHub Actions were passing locally, which led me to believe the issue might be with the tests themselves. After noticing some recent commits related to the tests, I decided to rebase. Everything seems to be passing now.

artieeez avatar Sep 26 '24 13:09 artieeez