core icon indicating copy to clipboard operation
core copied to clipboard

fix: Ensure that init is executed only once

Open ckken opened this issue 1 year ago • 4 comments

Description

Related Issue

Types of changes

  • [ ] Docs change / refactoring / dependency upgrade
  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)

Checklist

  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.
  • [ ] I have updated the documentation.

ckken avatar Sep 06 '24 10:09 ckken

⚠️ No Changeset found

Latest commit: 8d81534bdc514c4b14a2bb9cea44e20a15533780

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Sep 06 '24 10:09 changeset-bot[bot]

Deploy Preview for module-federation-docs ready!

Name Link
Latest commit 8d81534bdc514c4b14a2bb9cea44e20a15533780
Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/66e388703e7da5000849342a
Deploy Preview https://deploy-preview-2930--module-federation-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Sep 06 '24 10:09 netlify[bot]

users should be able to force re-init. i dont think we can early return the variable

@2heal1 is this correct?

ScriptedAlchemy avatar Sep 10 '24 21:09 ScriptedAlchemy

I'm sorry it can not be merged . Re-init is designed for users dynamic register remote/plugins/shared at the same time ,not call registerRemotes/registerPlugins one be one.

And it should not cause issue , what issue have you met ? If you want to registerRemotes , I recommend you to use registerRemotes

2heal1 avatar Sep 13 '24 02:09 2heal1

image image

ckken avatar Oct 24 '24 10:10 ckken

It is still necessary to ensure that init is only executed once

ckken avatar Oct 24 '24 10:10 ckken

Yes, init is stateful if you call init twice. You are updating the host or whatever the current instance is, not creating two instances.

My shareable runtime time PR introduces an instance manager, allowing you to share the runtime and make multiple instances.

ScriptedAlchemy avatar Oct 24 '24 18:10 ScriptedAlchemy

Yes, init is stateful if you call init twice. You are updating the host or whatever the current instance is, not creating two instances.

My shareable runtime time PR introduces an instance manager, allowing you to share the runtime and make multiple instances.

Hope to provide a demo!

ckken avatar Oct 28 '24 07:10 ckken