core icon indicating copy to clipboard operation
core copied to clipboard

@module-federation v2 runtime plugin - beforePreloadRemote args wrongly typed

Open Keitar6 opened this issue 1 year ago • 5 comments

Describe the bug

It seems that options should have entry property as well

2024-06-03 12_37_49-Greenshot image editor

And here is what does this property contain:

image

Reproduction

https://github.com/Keitar6/reproMF-chunks

Used Package Manager

npm

System Info

-

Validations

Keitar6 avatar Jun 03 '24 10:06 Keitar6

I patched a few of these already but will double check.

If you want to submit a PR. You Can you look in core.ts and will see all the hooks

ScriptedAlchemy avatar Jun 03 '24 11:06 ScriptedAlchemy

Okay, it would make more sense to just submit a PR for this, you are right. Thank you

Keitar6 avatar Jun 03 '24 11:06 Keitar6

I'm not the strongest TS dev lol. So you'll probably do it better than I 😂

ScriptedAlchemy avatar Jun 03 '24 12:06 ScriptedAlchemy

@Keitar6 are you able to open a pr?

ScriptedAlchemy avatar Jun 11 '24 21:06 ScriptedAlchemy

Yeah, sure, will do

Keitar6 avatar Jun 13 '24 05:06 Keitar6

Stale issue message

github-actions[bot] avatar Aug 12 '24 15:08 github-actions[bot]