mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Update types.ipynb , fixed typo

Open mcroni opened this issue 9 months ago • 3 comments

mcroni avatar May 05 '24 00:05 mcroni

Thanks for the fix. Do you mind targeting the nightly branch instead as the docs say? Otherwise, we won't be able to import this PR and merge it.

JoeLoser avatar May 15 '24 23:05 JoeLoser

can't seem to push to nightly

mcroni avatar May 15 '24 23:05 mcroni

can't seem to push to nightly

Did you follow along at https://github.com/modularml/mojo/blob/nightly/CONTRIBUTING.md#branching-off-nightly? You want to push to a local branch on your remote/fork - you can call that branch whatever you want as long as it's based off of the nightly branch from modularml/mojo repo.

JoeLoser avatar May 15 '24 23:05 JoeLoser

can't seem to push to nightly

Can you elaborate on what exactly is preventing you from doing so? See this comment for some suggestions on what to do.

Brian-M-J avatar May 24 '24 15:05 Brian-M-J

Actually, it seems this has already been fixed in the nightly branch (by me 😅). See commit 565586f

Brian-M-J avatar May 24 '24 15:05 Brian-M-J

Actually, it seems this has already been fixed in the nightly branch (by me 😅). See commit 565586f

Thanks - closing as such.

JoeLoser avatar May 29 '24 17:05 JoeLoser