mojo icon indicating copy to clipboard operation
mojo copied to clipboard

Update types.ipynb

Open nw31304 opened this issue 9 months ago • 1 comments

Minor typo corrections

nw31304 avatar May 04 '24 20:05 nw31304

Thanks for the fix. Do you mind targeting the nightly branch instead as the docs say? Otherwise, we won't be able to import this PR and merge it.

JoeLoser avatar May 15 '24 23:05 JoeLoser

The second typo fix has already been applied in the nightly branch by someone else; see commit 2d015fb.

I suggest you quickly rebase your branch on top of nightly to at least get your first fix in before someone else does. See here for some suggestions on how to do so.

Edit: Also, the first fix is the same one mentioned in modularml/mojo#2732

Brian-M-J avatar May 24 '24 15:05 Brian-M-J

The first fix has also been applied in #2818.

Brian-M-J avatar May 25 '24 17:05 Brian-M-J

Thank you for your responses. My apologies -- I wanted to contribute, but seem to have only wasted everyone's time. My bad.

nw31304 avatar May 25 '24 22:05 nw31304

The first fix has also been applied in #2818.

Thanks - closing this PR then.

JoeLoser avatar May 29 '24 17:05 JoeLoser