mojo icon indicating copy to clipboard operation
mojo copied to clipboard

[stdlib] Constrain `simd.bool()` to `size == 1`

Open helehex opened this issue 9 months ago • 5 comments

Use explicit reduce_or()/reduce_and() instead see https://github.com/modularml/mojo/pull/2412

helehex avatar May 04 '24 06:05 helehex

Actually, I wish they were called any and all.

soraros avatar May 04 '24 14:05 soraros

i was thinking the same thing, but they can be separate to avoid bitwise ambiguity

helehex avatar May 04 '24 16:05 helehex

Just a quick update here: this has been approved internally, but I need to go fix up more uses internally this breaks before we can land it.

JoeLoser avatar May 09 '24 04:05 JoeLoser

I was about to try adding any/all functions, but my Internet connection just died, so if anyone wants something todo

edit: I did it anyway, but can't open the pr till I get online...

helehex avatar May 09 '24 06:05 helehex

I thought there was something else that should get done before any/all, but I can't remember now

helehex avatar May 09 '24 06:05 helehex

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

modularbot avatar May 18 '24 00:05 modularbot

Landed in a31a0e6c3a1f8bc8df5583d1cbc4f23c8e0bf7d3! Thank you for your contribution 🎉

modularbot avatar May 18 '24 05:05 modularbot