mojo icon indicating copy to clipboard operation
mojo copied to clipboard

[stdlib] Support print to stderr

Open GeauxEric opened this issue 9 months ago • 3 comments

Add keyword argument to print function to support stream to stderr.

Fix #2453

Signed-off-by: Yun Ding [email protected]

GeauxEric avatar May 01 '24 05:05 GeauxEric

Thanks for working on this @GeauxEric!🙂

I left a couple of small suggestions, but I noticed this PR is still in 'Draft' mode, so I'll hold off on leaving any more feedback until you indicate you're ready :)

ConnorGray avatar May 01 '24 20:05 ConnorGray

@GeauxEric could I suggest that you rebase this PR on top of #2463 ? This should make this pull request quite a bit smaller in the end, as there will be less code to change.

gabrieldemarmiesse avatar May 02 '24 09:05 gabrieldemarmiesse

rebased https://github.com/modularml/mojo/pull/2463

GeauxEric avatar May 04 '24 19:05 GeauxEric

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

modularbot avatar May 10 '24 23:05 modularbot

Landed in today's nightly: https://github.com/modularml/mojo/pull/2615. Thanks for the contribution! @modocache is eager to start using this.

JoeLoser avatar May 11 '24 03:05 JoeLoser

Absolutely! Thanks a ton, @GeauxEric!

modocache avatar May 11 '24 12:05 modocache