modular-admin-html icon indicating copy to clipboard operation
modular-admin-html copied to clipboard

input-groups are using wrong class and markup

Open cadu-leite opened this issue 6 years ago • 2 comments

the actual makup at app/forms/input-groups.hbs is

    <div class="input-group">
        <span class="input-group-addon">$</span>
        <input type="text" class="form-control" placeholder="Some text here">
        <span class="input-group-addon">.00</span>  <!- input-group-addon class is no more -->
    </div>

when I believe it should be

    <div class="input-group">
        <div class="input-group-prepend">  <!-  for prepend - need a outer div.input-group-XXXX -->
            <span class="input-group-text">@</span> <!-  input-group-text is the new class -->
        </div>
        <input type="text" class="form-control" placeholder="Some text here">
    </div>

    <div class="input-group">
        <input type="text" class="form-control" placeholder="Input with append text">
        <div class="input-group-append">  <!-  for append -->
            <span class="input-group-text">.00</span>
        </div>
    </div>

this is not the look&feel it should have

screen shot 2018-03-12 at 16 52 06

cadu-leite avatar Mar 12 '18 19:03 cadu-leite

@cadu-leite thanks a lot! Will try to fix this as soon as possible. Or can you make a pull request for this fix?

Thanks!

modularcoder avatar Mar 13 '18 10:03 modularcoder

sure ... Glad to help ... may I'll take some time ... finishing a demo @ my job.

cadu-leite avatar Mar 13 '18 15:03 cadu-leite