labrinth icon indicating copy to clipboard operation
labrinth copied to clipboard

Project update notifications break when the corresponding version is deleted

Open xXNickznXx opened this issue 2 years ago • 0 comments

Describe the bug

There are broken notifications that point to a version of a project that no longer exists.

What it looks like in the frontend. I managed to reach this state, because I'm currently building an app that makes it possible to manage the notifications in more detail. When fetching the corresponding versions, the incorrect notifications were filtered out. Marking the rest as read and voila: image

The corresponding links:

  • https://modrinth.com/project/POQ2i9zu/version/3g8WRtyl
  • https://modrinth.com/project/LQ3K71Q1/version/eutlHy4y
  • https://modrinth.com/project/qnQsVE2z/version/CQY4uRIc
  • https://modrinth.com/project/9eGKb6K1/version/NcfPfBr7
  • https://modrinth.com/project/Xy8aRQKS/version/p2rnVdjo

Even funnier "Combat Roll" (the last one) actually has 3 broken notifications, but only shows up as one:

  • https://modrinth.com/project/wGKYL7st/version/b6GGrwSH
  • https://modrinth.com/project/wGKYL7st/version/BM98V7il
  • https://modrinth.com/project/wGKYL7st/version/ocm6tRtX

Steps to reproduce

Not really reproducible since you must be "lucky" to achieve this.

Expected behavior

These should either be filtered out when the endpoint "https://api.modrinth.com/v2/user/{id|username}/notifications" is used or outright removed when the corresponding version is removed.

Additional context

No response

xXNickznXx avatar Oct 16 '23 00:10 xXNickznXx