labrinth icon indicating copy to clipboard operation
labrinth copied to clipboard

Initial project creation still allows non-unique version numbers

Open navarayuk opened this issue 2 years ago • 4 comments

Environment

Website

Describe the bug

little but I seen, if you have 2 mod updates and versions builds for 2 different version of MC it wont let you edit the other it's defaults to the 1.16.5 and wont let me edit the 1.18.2

image

No matter witch I click it opens the 1.16.5 version Release version do and will have the same name so maybe change it to mod/modsID/mcversion/version/1.5.0.3 eg mod/netherclone/1.16.5/version/1.5.0.3

rather then just mod/netherclone/version/1.5.0.3

Steps To Reproduce

Upload 2 mod versions 1.16.5 and 1.18.2 what are the same version number EG 1.5.0.0 add all information, leave the second file with no change log at this time. update files, first file give a change log.

go to your version files once updated and go edit, you will see it will open the last version with no change log only.

I found this out when I was meant to put in my 1.18.2 just port and 1.16.5 was meant to have the change log.

Expected behavior

Expected to be able to edit each version in the version list so 1.16.5 and 1.18.5 should be under there MC versions and be able to be edited not under one global version.

Additional context

To fix this I would say save each version under there MC version and then when we call them back in to versions we can see them with there own change logs, we can still group versions together but let each version have there own change log.

navarayuk avatar Aug 02 '22 13:08 navarayuk

Mod versions are meant to be unique, not sure how you managed to make two with the same number but there are multiple guards in place to prevent that from happening

triphora avatar Aug 02 '22 14:08 triphora

Mod versions are meant to be unique, not sure how you managed to make two with the same number but there are multiple guards in place to prevent that from happening

This isn't mods this is the jar files after you create the mod project image

These files should and can be named the same thing as they are the same thing just different versions, look at CF they do it this way also so this needs to be changed, if you don't want this way you have to make that clear as it makes not sense to have very build for different versions have different names.

a 1.5.0.0 codename nightly would be the same name for both versions 1.16.5 and 1.18.2 and so on.

Example from CF image

navarayuk avatar Aug 02 '22 15:08 navarayuk

Yes, I was talking about version numbers, not version titles. Version numbers are meant to be unique and that's why you're encountering those issues.

triphora avatar Aug 02 '22 15:08 triphora

Yes, I was talking about version numbers, not version titles. Version numbers are meant to be unique and that's why you're encountering those issues.

Ya above or next to the version number make sure you mean version-mc eg 1.0.0.0-1.16.5 so it's little less confusing and also fixing the problem where it was able to save them both lol not sure how I broke that :D

navarayuk avatar Aug 02 '22 16:08 navarayuk

The unique requirement on versions has been dropped in #414 after some discussion and frontend changes to accommodate it.

triphora avatar Aug 15 '22 10:08 triphora