labrinth icon indicating copy to clipboard operation
labrinth copied to clipboard

Version ordering wrong/certain MC versions not recognised for display in "Featured Versions" section.

Open Sollace opened this issue 2 years ago • 4 comments

The way modrinth orders versions for inclusion into the "Featured Versions" section is weird and unpredictable. I expect the featured versions list to work like a shortcut to see what Minecraft release versions a mod supports, so it should, obviously, include at least display a mod version for every major (not snapshot, pre-release, or release candidate) version of Minecraft for which that mod has a version.

For example, if I have versions that are tagged like this: a. 1.16.1, 1.16.2, 1.16.3 b 1.17.0, 1.17.1 c 1.17.0, 1.17.1, 1.17.2 d 1.18 e 1.18, 1.18.1-pre

I expect the list to show: a (1.16.3) b (1.17.1) c (1.17.2) e (1.18)

Instead modrinth is producing a list like this (incorrectly leaving out the 1.18 version, and incorrectly including the 1.18.1-pre version): a (1.16.3) b (1.17.1) c (1.17.2) e (1.18.1-pre)

Then when I add a 1.18.1 version, the list changes to this (again missing 1.18): a (1.16.3) b (1.17.1) c (1.17.2) f (1.18.1)

To take a more real world example, this mod has four versions, including 1.17 and 1.18 versions, and yet only two appear in the list.

a 1.16.3, 1.16.4, 1.16.5, 20w48a, 20w49a b 1.17.1, 1.17-rc1 c 1.18-pre8, 1.18-rc1, 1.18-rc2, 1.18-rc3, 1.18-rc4 d 1.18

has weirdly been translated into: a (20w49a) - snapshot b (1.17-rc1) - release candidate

And for completeness, this is what I expect for this project: a 1.16.5 b 1.17.1 d 1.18

Relevant screenshots: image

!

Sollace avatar Dec 13 '21 16:12 Sollace

Another example: Modrinth shows one 1.16 version, skips over aaaaalllll of 1.17, then shows the wrong version for 1.18.

image

Sollace avatar Dec 13 '21 16:12 Sollace

The download counts also show the effects of this, as people are downloading the featured versions, rather than going to the full list to get the more up-to-date ones. I'm worried that this bug is leading people to think mods are not updated when they very clearly are (if you check the full version list).

Sollace avatar Dec 13 '21 16:12 Sollace

The featured versions have been improved in terms of being able to view in the frontend which ones are to be featured or not, and whether things are featured because they were manually set like that or whether they were automatically tagged as featured.

It should be creating automatically featured version for every major version and for every loader with a major version attached. Whether a version is major or not can be determined from this endpoint. For example, the five latest featured versions are 1.18.2, 1.17.1, 1.16.5, 1.16.1, and 1.15.2.

Could you test around and see whether the system is easier to use for you now?

triphora avatar Mar 05 '22 20:03 triphora

The featured versions have been improved in terms of being able to view in the frontend which ones are to be featured or not, and whether things are featured because they were manually set like that or whether they were automatically tagged as featured.

It should be creating automatically featured version for every major version and for every loader with a major version attached. Whether a version is major or not can be determined from this endpoint. For example, the five latest featured versions are 1.18.2, 1.17.1, 1.16.5, 1.16.1, and 1.15.2.

Could you test around and see whether the system is easier to use for you now?

It does feel better, yes. I noticed the change last week when I went to update my mods. What I found initially is when I uploaded 1.18.2 versions, they weren't featured, but then I saw I could manually mark them as featured so I did that.

Only issue is that after I marked the new version as featured, the site removed all previously featured versions and I had to manually add them all back.

Sollace avatar Mar 07 '22 16:03 Sollace

has been fixed in the frontend

Geometrically avatar Apr 27 '23 23:04 Geometrically