knossos icon indicating copy to clipboard operation
knossos copied to clipboard

Mod Manager Integration

Open trash-pandy opened this issue 3 years ago • 4 comments

A partial implementation for issue #380. Currently adds a button next to any downloads that launches a protocol handler intended to be received by an application on the user's computer that is configured to handle it. The protocol handler currently takes the form modrinth:/add-item/<version-id>, where <version-id> is the version of the item selected to be downloaded. The button can be enabled by adding the manager-integration parameter to the page URL, which is intended to be used by the application referenced above.

trash-pandy avatar Mar 11 '22 07:03 trash-pandy

Maybe have the button always be there but unless the cookie has been set have it open to the modrinth official launcher page?

MulverineX avatar Apr 08 '22 23:04 MulverineX

Maybe have the button always be there but unless the cookie has been set have it open to the modrinth official launcher page?

Perhaps in future, when Theseus is in a more useable state, but that day is yet to come.

trash-pandy avatar Apr 08 '22 23:04 trash-pandy

There were some major merge conflicts that I found were much easier to resolve by resetting my fork to the latest upstream commit and re-adding what I had written.

trash-pandy avatar May 30 '22 19:05 trash-pandy

@trash-panda-mc is attempting to deploy a commit to the modrinth Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar May 30 '22 19:05 vercel[bot]

Hey @trash-pandy! Would it be possible for you to recreate this PR on master? We're still interested in getting this merged, but the rewrite is on hold the foreseeable future, so it would be better to add this to the current Nuxt site.

triphora avatar Nov 13 '22 15:11 triphora

If this gets merged, probably would be good to let launchers know this is planned so they can add it before the button appears (I see the polymc one above, but it's still open, and prism is the new poly so)

Also maybe the link should be a bit different, as add-item sounds weird for stuff like modpacks

Minenash avatar Nov 13 '22 18:11 Minenash

Closing in favor of #783

triphora avatar Nov 29 '22 00:11 triphora