knossos icon indicating copy to clipboard operation
knossos copied to clipboard

`LICENSE.md` is meant to be plaintext, not markdown.

Open ImperatorStorm opened this issue 2 years ago • 2 comments

Environment

No response

Describe the bug

The AGPLv3 is meant to be displayed as plaintext. Having LICENSE be markdown has it run through a markdown processor, breaking formatting.

Steps To Reproduce

No response

Expected behavior

Expected formatting

Expected formatting

Current formatting

Current formatting

Additional context

Possibly oversight with https://github.com/modrinth/knossos/commit/4b1b2878eaf0c0ada4a58489a0bb2589b7d9702c that was never noticed or rectified?

ImperatorStorm avatar Jan 19 '22 23:01 ImperatorStorm

To add to OP's comment;

LICENSE.md is supposed to be a markdown file whereas LICENSE or LICENSE.txt is supposed to be a plaintext file. If Modrinth wishes to use a markdown or plaintext license, it would be appropriate to use the correct extension and match it with the correct file format.

The GNU Affero General Public License offers both a plaintext and a markdown file.

NatoBoram avatar Jan 26 '22 20:01 NatoBoram

a markdown file.

This should be used. It provides better formatting.

Secret-chest avatar Mar 04 '22 16:03 Secret-chest

Fixed in #819

triphora avatar Dec 28 '22 06:12 triphora