knossos icon indicating copy to clipboard operation
knossos copied to clipboard

add open in app button to mod & modpack project pages

Open evergales opened this issue 1 year ago • 2 comments

I noticed that theseus takes 'modrinth://' deeplinks for mods and modpacks

I thought it would be nice to add an 'open in app' button to those pages because as far as I know there is currently no way (other than pasting code into console) to use unlisted mods or modpacks in the launcher and this could be a convenient way to make that a bit better along with just being a nice qol feature

https://github.com/modrinth/knossos/assets/97823982/dd5405a2-5bce-467b-8799-8e45ef0da3a4

I wasn't sure about making a thread for this in discord but can if needed!

evergales avatar Jun 15 '24 11:06 evergales

We had planned on implementing it a different way, but I think doing it this way would be great for now!

One thing is, this should work for anything except for a mod that only supports plugin loaders I believe, since the Modrinth App supports everything but plugins.

Prospector avatar Jun 15 '24 12:06 Prospector

I think it should be correct now ~~but #1227 needs to be fixed and I also think UrlConfirmModal is grabbing old project versions when installing~~ fixed in: theseus/#1228

evergales avatar Jun 15 '24 13:06 evergales