knossos icon indicating copy to clipboard operation
knossos copied to clipboard

Move extra loaders and change RP Resolutions to use OR

Open Minenash opened this issue 2 years ago • 3 comments

Right now, when the user clicks on More to show the rest of the loaders, the extra loaders are intermixed with the original. This is unitutive, and makes it harder to find what you're looking for and to see what loaders are the ones behind the more.

This PR fixes that by putting all the loaders hidden by More at the bottom of the list

Edit: Now also fixes #953, which changes the Resource Pack Resolution filters to be OR instead of AND

Minenash avatar Oct 05 '23 04:10 Minenash

I also had that thought. I didn't realize loaders were listed in composables/tag.js. The list could be added there

Minenash avatar Oct 05 '23 06:10 Minenash

Should it be a list major loaders, or hidden loaders

Minenash avatar Oct 05 '23 15:10 Minenash

My original plan was just to do
:active-filters="header === 'resolutions' ? orFacets : facets"
@toggle="header === 'resolutions' ? toggleOrFacet : toggleFacet "

But the toggle one didn't work, so unless there's a way to do it, I ended up duplicating the search filter.

Using orFacets should be safe, since the only other thing that used them was loaders, but you don't have access to loaders on resource packs.

This does mean however that resolutions now use the g instead of f parameter, but the letter was going to have to change anyways

Minenash avatar Oct 06 '23 04:10 Minenash