knossos icon indicating copy to clipboard operation
knossos copied to clipboard

"Subscribe to updates" button doesn't have a focus outline

Open MMK21Hub opened this issue 2 years ago • 1 comments

Describe the bug

On the sign up page, in the first-party auth section, there's a button (styled as a checkbox) that says "Subscribe to updates about Modrinth". However, when it is focused on, there is no visual indication of its focus state.

This issue also affects the welcome page, which has an identical button.

Steps to reproduce

  1. Go to https://modrinth.com/auth/sign-up
  2. Click on the "Confirm password" field
  3. Press Tab to move focus to the "subscribe to updates" button

Expected behavior

There would be a focus ring around the whole button (or maybe just the checkbox icon)

Additional context

Screenshot of the main card on the "Welcome to Modrinth!" page Screenshot of the main card on the auth sign-up page

MMK21Hub avatar Aug 14 '23 15:08 MMK21Hub

Omorphia's Checkbox css on has outline:none, which is absent in Knossos's Checkbox css. It also takes priority over the css dealing with focus.

Will most likely be a fix on Omorphia's side

Minenash avatar Oct 06 '23 04:10 Minenash