modrinth
Search: Advert position swaps place when filter menu is opened
Describe the bug
On mobile viewports, filters can be used by pressing the Filters... button to "open" the card containing the filters.
When this card is closed, the advert (tagged with the class GBBNWLJVGRHFLYVGSZKSSKNTHFYXHMBD) appears below the search controls. However, when the filters are open, the advert is shown above the search controls.
This upsets the expected order of UI elements, and also stops the focus order matching the visual order of elements.
Steps to reproduce
- Use a viewport less than 1024px wide
- Go to https://modrinth.com/mods → :heavy_check_mark: The advert is above the search controls
- Click the Filters... button → :x: The advert is now below the search controls
Expected behavior
The advert would stay above the search controls (the top-to-bottom order would be filters card, advert, search controls, pagination, search results)
Screenshots
Expected behaviour (when filters aren't shown)
Unexpected behaviour (when filters are shown)
I'm still able to reproduce this on the production site, as well as staging.modrinth.com (commit fcfa508). The visual inconsistency and the incorrect tab order are both still present.