Game instances are closing on lauch

Open DrParadox7 opened this issue 2 years ago • 1 comments

Describe the bug

Upon launching an 1.7.10 instance Theseus will have a 50% chance to completely fail to initiate a the game due to a NoSuchMethodError.

The issue is 1.7.10 Forge needs Guava 17, but Theseus puts both Guava 17 and Guava 15 on the classpath, and randomizes the order (not sure if intentionally or not). Whenever 15 ends up first, this error happens, since Forge is looking for a method that didn't exist yet in 15.

This only occurs since Theseus v0.6.1. I still use version 1.6.0 without issues.

For comparison, MultiMC only puts Guava 17 on the classpath and it reliably launches every time.

Steps to reproduce

Launch any 1.7.10 instance
50% chance it will terminate the instance prematurely

https://mclo.gs/uJCINZh (empty 1.7.10, no mods)

Expected behavior

For Theseus to launch instances reliably

System information

Windows 10, Theseus v0.6.2

Additional context

No response

Nov 23 '23 16:11 DrParadox7

Introduced since PR https://github.com/modrinth/theseus/pull/863. Specifically, the changes done to theseus/src/launcher/args.rs.

Apr 06 '24 23:04 DrParadox7