code icon indicating copy to clipboard operation
code copied to clipboard

MIT-0 SPDX identifier not detected

Open Thinkseal opened this issue 10 months ago • 10 comments

Please confirm the following.

What browsers are you seeing the problem on?

Firefox, Chrome (including Arc, Brave, Opera, Vivaldi)

Describe the bug

If I set your licence to MIT No Attribution using the SPDX identifier MIT-0 it does not detect it

Steps to reproduce

  1. make a project on modrinth
  2. set licence to MIT-0
  3. it is not detected

Expected behavior

It should detect it as MIT No Attribution and it should be clickable on the project page

Image

Additional context

I discovered this because I wanted to see if modrinth detected MIT No Attribution as an open source licence as it is OSI Approved.

Thinkseal avatar Mar 06 '25 15:03 Thinkseal

We could maybe detect it and show the content but I'm not sure if it's worth it. I wouldn't add it to the dropdown, there are over 100 OSI approved licenses.

piprett avatar Mar 06 '25 16:03 piprett

I believe this is a broader issue with the SPDX identifier checkbox just not working in certain scenarios. If I edit it through the API it works fine

Image

triphora avatar Mar 06 '25 16:03 triphora

I believe this is a broader issue with the SPDX identifier checkbox just not working in certain scenarios.

Even when I got it to be bugged and it didn't force me to check the checkbox it would still check it afterwards when I reloaded the page

Thinkseal avatar Mar 06 '25 17:03 Thinkseal

I just tried to change it to mit and some weird stuff happened first try it did not work but when I went back to the license page it had then auto detected it and set it to mit (not using SPDX identifier but the drop down menu one) and it was not saved so I saved it and it worked but the second time I tried it just checked the box for it not having a SPDX identifier when I reloaded and it was saved.

I think something may be very wrong with the lenience system right now.

Thinkseal avatar Mar 10 '25 12:03 Thinkseal

If you're talking about Bad Apple Shaders, I'm preeeety sure I've done something wrong if it was meant to link somewhere perhaps due to not needing any attribution or literally anything it doesn't link to it?

blryface avatar Mar 10 '25 13:03 blryface

Image It works perfectly fine, I think I accidentally clicked the "Does not have SPDX Identifier" before.

blryface avatar Mar 10 '25 13:03 blryface

I believe this is a broader issue with the SPDX identifier checkbox just not working in certain scenarios.

The checkbox is for when the license does not have one, it seems?

blryface avatar Mar 10 '25 13:03 blryface

It is, I just checked. Although, it does seem like it enabled itself, because I had just saved with it not ticked, went to see the page, and when coming back to check the settings, it was ticked

blryface avatar Mar 10 '25 13:03 blryface