code icon indicating copy to clipboard operation
code copied to clipboard

Server Manager content installation should include dependencies

Open 6TELOIV opened this issue 10 months ago • 0 comments

Please confirm the following.

  • [x] I checked the existing issues for duplicate feature requests
  • [x] I have checked that this feature request is not on our roadmap

What parts of Modrinth is your feature request related too?

Website, App

Is your suggested feature related to a problem? Please describe.

When installing content to a server instance, dependencies of that content are not included. This differs from the launcher app behavior, where installing content automatically installs dependencies as well.

Describe the solution you'd like

Installing content on the server should include that version's dependencies.

Describe alternatives you've considered

I looked into contributing the feature myself, but it looks like the pyro server API is not open source, and I don't want to assume how a feature like this should be built out. If a team member can give guidance on the desired implementation, I don't mind adding this!

Additional context

The feature can be implemented either on the pyro codebase, or within this codebase.

The actual server content installation is happening here: https://github.com/modrinth/code/blob/main/apps/frontend/src/composables/pyroServers.ts#L614 so either pyro should fetch the dependencies and install them as well, or modrinth should figure out the dependencies and include them in this function call. To me, I think this should live on modrinth, as otherwise, it requires multiple round trips to install (modrinth POSTs to pyro, pyro GETs from modrinth for metadata)

Likely, this code can be reused from the launcher app, though I couldn't identify where that code is.

6TELOIV avatar Mar 05 '25 16:03 6TELOIV