code icon indicating copy to clipboard operation
code copied to clipboard

`Install with Modrinth App` is broken due to incorrect registry path

Open Felix14-v2 opened this issue 1 year ago • 2 comments

Please confirm the following.

  • [X] I checked the existing issues for duplicate problems
  • [X] I have tried resolving the issue using the support portal
  • [X] I have ensured my Modrinth App installation is up to date

Info

  • Modrinth App 0.8.2
  • Windows 11

Description

The «Install with Modrinth App» button won't work if a path to the launcher .exe contains spaces:

https://github.com/user-attachments/assets/2dc951de-25ba-4778-a431-c41c541e8185

This happens due to incorrect registry path that Modrinth App sets on each launch (that's why I can't fix it myself):

Light theme alert! Actually this window doesn't support the dark theme at all, Windows sucks

image

To reproduce

  1. Create a user with a space in the name
  2. Install Modrinth App
  3. Try to install something from the website

Expected behavior

The path should be wrapped in quotation marks: "C:\Users\Домашний компьютер\AppData\Local\Modrinth App\Modrinth App.exe" "%1"

After fixing the path manually the button works fine until the next App launch.

Additional context

Thread in Discord

Felix14-v2 avatar Aug 23 '24 18:08 Felix14-v2

Confirmed to be fixed in 0.8.5

Felix14-v2 avatar Aug 31 '24 12:08 Felix14-v2

Confirmed to be broken again in 0.8.7 – App installs its update to a different directory (Program Files/Modrinth App instead of %LocalAppData%/Modrinth App) and doesn't update its location in the registry

Felix14-v2 avatar Sep 13 '24 09:09 Felix14-v2

I'm also having similar path related issues, but with things like changing instance icon or adding non-modrinth mod through modrinth app. #2444

denisJaved avatar Sep 29 '24 03:09 denisJaved