modrinth
Theseus Skin Manager
Adds a skin manager page to the app, where users can view/change their current skin, as well as store saved skins.
Resolves #415 Resolves #866
(Note the input search bar is broken across the whole app since monorepo change, and is not a skin manager issue Edit: this has been fixed)
First of all thank you, I've been waiting for this feature for a long time. I would like to suggest some improvements about your work.
Main skin manager window:
Regarding the main screen, I suggest you order "Add new skin" as the last one, in my opinion it makes more sense for it to be at the end.
Change skin window:
I suggest you leave a small empty space under "Cape" section
Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).
Lastly, I think it is redundant to use 3 different buttons for use, save and save+use. I think using the skin without saving it doesn't make much sense as the user can delete or modify it immediately afterwards anyway.
- New skin: Cancel* | Upload (Means use+save)
- Saved skin: Cancel* | Delete | Save | Re-Upload (Means save+use)
~~*Redundant as it is already present in the top right corner (the X could be replaced with the 'Cancel' buttom).~~
Also, if it is not already present, I suggest adding the possibility to change the cape without changing the skin. (Otherwise, if I only wanted to change the cape, I would have to create a new skin each time).
I'll make it so the "add new skin" button autofills the current skin, so you can change the cape or arms and click upload. The cancel buttons are on all modals in the app, so removing it would go against the current modal styling
@IntMarco Thank you for the feedback
it would also be a great feature to make the capes display what they look like, only challenge I see with that though is making it not crash if, say, Mojank releases a new cape without Modrinth needing an update
it would also be a great feature to make the capes display what they look like, only challenge I see with that though is making it not crash if, say, Mojank releases a new cape without Modrinth needing an update
Selecting a cape shows it in the 3d viewer
absolutely awesome, all for it then, I just didn't want to be the guy who opens an enhancement a week after a feature gets added
Going to merge this into a branch on our repo to make working with it a bit easier. Thanks for your contribution!
