modrinth
Support environment variables for the profile hooks
Is your suggested enhancement related to a problem? Please describe.
It's not directly related to a specific issue or bug, yet it makes it hard to share instances as we have to hardcode paths like the instance directory or the Java binary executable.
See MultiMC Custom Commands for details.
Describe the solution you'd like
The simplest solution is to simply replace the supported variables like $INST_MC_DIR with something like C:\Users\%USERPROFILE%\AppData\Roaming\com.modrinth.theseus\profiles\Test1on Windows for example, the instance directory path is already available in the current code, we just have to replace it or pass it to for example, allow using it in the commands to run a JAR file that exists in the instance directory.
I suggest to support the following for compatibility:
-
$INST_NAME: The name of the instance -
$INST_ID: The name of the instance's root directory -
$INST_DIR: The absolute path to the instance directory -
$INST_MC_DIR: Alias for $INST_DIR -
$INST_JAVA: The absolute path to the java executable used for launch -
$INST_JAVA_ARGS: The JVM parameters used for the launch
As they are widely supported in launchers like MultiMC, Prism Launcher, and even other launchers that are not based on MultiMC.
Describe alternatives you've considered
For now, we will have to hardcode the full path to the Java installed on the launcher and the instance path, making it hard to share with other users.
Additional context
Examples of launchers that support this feature:
Related issues:
- #952
This feature request seems to be already in the TODO list: https://github.com/modrinth/code/blob/0f2ddb452cc3baeb85a9a9d1e00dc43ba6b1517d/packages/app-lib/src/api/profile/mod.rs#L781
