code icon indicating copy to clipboard operation
code copied to clipboard

Mark client-only mods as unsupported for servers in exports

Open JulianVennen opened this issue 1 year ago • 1 comments

When you export a mrpack all mods are always marked as required. This generally works fine for the client, since most "server-only" mods usually target the logical server and are still useful in single player. For servers, however, this causes many issues. "Client-only" mods often cause crashes when running on a dedicated server.

This PR marks mods that do not support servers as unsupported on the server, which fixes #911 and #1081.

Ideally, the modpack author would have the option to pick which mods to include on the server and client and which mods should be optional. The behavior of this PR should still be the default selection for this menu due to the reasons mentioned above.

JulianVennen avatar Apr 25 '24 14:04 JulianVennen

The PR that introduces the previous code (#703) references #665 as the reason for these changes, which only concerns optional mods and therefore isn't really affected by this.

JulianVennen avatar Apr 25 '24 14:04 JulianVennen