modoboa-installer icon indicating copy to clipboard operation
modoboa-installer copied to clipboard

Make passwd for postgres too

Open ionescu77 opened this issue 4 years ago • 6 comments

Description of the issue/feature this PR addresses:

Modoboa-installer installation on Centos 7.6, with Postgresql would fail. This would happen if the user does not specify password and goes on with default setting.

see Issue #296

Current behavior before PR:

Actually the clamav and other modules dependant on the DB would fail starting.

Desired behavior after PR is merged:

After I modified the postgres entry to look like mysql (make_password, instead of empty default), I was able to complete the install script and have all services running.

ionescu77 avatar Apr 17 '20 13:04 ionescu77

Codecov Report

Base: 50.07% // Head: 50.07% // No change to project coverage :thumbsup:

Coverage data is based on head (bcb754c) compared to base (06a81c7). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   50.07%   50.07%           
=======================================
  Files          10       10           
  Lines         681      681           
=======================================
  Hits          341      341           
  Misses        340      340           
Impacted Files Coverage Δ
modoboa_installer/config_dict_template.py 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Apr 17 '20 13:04 codecov[bot]

I first tried to address this in PR #304 , however my fork was out of sync therefore too many differences would show up in Files Changed. Now it is just this tinny modification.

ionescu77 avatar Apr 17 '20 13:04 ionescu77

@ionescu77 Thank you. Have you tried your modification on a Debian/Ubuntu system?

tonioo avatar Jun 02 '20 18:06 tonioo

Bon soir.

No debian/Ubuntu at hand.

I had to reinstall my mail server on centos 7 and bumped into this again.

With this small modification it worked.

I'm not sure I can experiment on ubuntu this weeks are a bit busy for me :-/

Best,

Raz

On 2. Jun 2020, at 21:38, Antoine Nguyen [email protected] wrote:

 @ionescu77 Thank you. Have you tried your modification on a Debian/Ubuntu system?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

ionescu77 avatar Jun 02 '20 19:06 ionescu77

Hello,

Bon soir. No debian/Ubuntu at hand. [...] I'm not sure I can experiment on ubuntu this weeks are a bit busy for me :-/ Best, Raz

Did u got less busy? Tests done?

Regards

ksaadDE avatar Jun 27 '22 18:06 ksaadDE

@ksaadDE Hello, man I am not using debian/ubuntu at work I have only centos and only an old Ubuntu 18.04.6 LTS running the network management software, and I'm reluctant to use it.

If somebody please has some Ubuntu lying around :(

If you look at the commit it's a one liner, basically the make_password function was never called. I did not do any modoboa deployment since then.

ionescu77 avatar Jun 28 '22 13:06 ionescu77